Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fsx ontap_volume resource #21889

Merged
merged 7 commits into from
Nov 25, 2021
Merged

Add fsx ontap_volume resource #21889

merged 7 commits into from
Nov 25, 2021

Conversation

awsaxeman
Copy link
Contributor

@awsaxeman awsaxeman commented Nov 24, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20778

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccFSxOntapVolume' PKG_NAME=internal/service/fsx TEST_COUNT=1 ACCTEST_PARALLELISM=10
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 10 -run=TestAccFSxOntapVolume -timeout 180m
=== RUN   TestAccFSxOntapVolume_basic
=== PAUSE TestAccFSxOntapVolume_basic
=== RUN   TestAccFSxOntapVolume_disappears
=== PAUSE TestAccFSxOntapVolume_disappears
=== RUN   TestAccFSxOntapVolume_name
=== PAUSE TestAccFSxOntapVolume_name
=== RUN   TestAccFSxOntapVolume_junctionPath
=== PAUSE TestAccFSxOntapVolume_junctionPath
=== RUN   TestAccFSxOntapVolume_securityStyle
=== PAUSE TestAccFSxOntapVolume_securityStyle
=== RUN   TestAccFSxOntapVolume_size
=== PAUSE TestAccFSxOntapVolume_size
=== RUN   TestAccFSxOntapVolume_storageEfficiency
=== PAUSE TestAccFSxOntapVolume_storageEfficiency
=== RUN   TestAccFSxOntapVolume_tags
=== PAUSE TestAccFSxOntapVolume_tags
=== RUN   TestAccFSxOntapVolume_tieringPolicy
=== PAUSE TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_basic
=== CONT  TestAccFSxOntapVolume_size
=== CONT  TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_tags
=== CONT  TestAccFSxOntapVolume_storageEfficiency
=== CONT  TestAccFSxOntapVolume_junctionPath
=== CONT  TestAccFSxOntapVolume_securityStyle
=== CONT  TestAccFSxOntapVolume_name
=== CONT  TestAccFSxOntapVolume_disappears
--- PASS: TestAccFSxOntapVolume_disappears (2888.40s)
--- PASS: TestAccFSxOntapVolume_storageEfficiency (3001.53s)
--- PASS: TestAccFSxOntapVolume_basic (3041.62s)
--- PASS: TestAccFSxOntapVolume_size (3104.32s)
--- PASS: TestAccFSxOntapVolume_tags (3197.11s)
--- PASS: TestAccFSxOntapVolume_junctionPath (3199.21s)
--- PASS: TestAccFSxOntapVolume_securityStyle (3447.24s)
--- PASS: TestAccFSxOntapVolume_tieringPolicy (3598.40s)
--- PASS: TestAccFSxOntapVolume_name (3668.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        3673.397s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Nov 24, 2021
@DrFaust92
Copy link
Collaborator

Depends on #21780

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. examples Introduces or discusses updates to examples. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/account Issues and PRs that pertain to the account service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appstream Issues and PRs that pertain to the appstream service. service/athena Issues and PRs that pertain to the athena service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/configservice Issues and PRs that pertain to the configservice service. service/dlm Issues and PRs that pertain to the dlm service. service/docdb Issues and PRs that pertain to the docdb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Nov 25, 2021
@github-actions github-actions bot removed service/quicksight Issues and PRs that pertain to the quicksight service. service/wafv2 Issues and PRs that pertain to the wafv2 service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. examples Introduces or discusses updates to examples. linter Pertains to changes to or issues with the various linters. service/apprunner Issues and PRs that pertain to the apprunner service. sweeper Pertains to changes to or issues with the sweeper. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/account Issues and PRs that pertain to the account service. labels Nov 25, 2021
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@awsaxeman awsaxeman changed the title [WIP] Add fsx ontap_volume resource Add fsx ontap_volume resource Nov 25, 2021
@awsaxeman awsaxeman marked this pull request as ready for review November 25, 2021 08:25
DrFaust92
DrFaust92 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @awsaxeman for the contribution!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccFSxOntapVolume' PKG_NAME=internal/service/fsx TEST_COUNT=1 ACCTEST_PARALLELISM=10
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 10 -run=TestAccFSxOntapVolume -timeout 180m
=== RUN   TestAccFSxOntapVolume_basic
=== PAUSE TestAccFSxOntapVolume_basic
=== RUN   TestAccFSxOntapVolume_disappears
=== PAUSE TestAccFSxOntapVolume_disappears
=== RUN   TestAccFSxOntapVolume_name
=== PAUSE TestAccFSxOntapVolume_name
=== RUN   TestAccFSxOntapVolume_junctionPath
=== PAUSE TestAccFSxOntapVolume_junctionPath
=== RUN   TestAccFSxOntapVolume_securityStyle
=== PAUSE TestAccFSxOntapVolume_securityStyle
=== RUN   TestAccFSxOntapVolume_size
=== PAUSE TestAccFSxOntapVolume_size
=== RUN   TestAccFSxOntapVolume_storageEfficiency
=== PAUSE TestAccFSxOntapVolume_storageEfficiency
=== RUN   TestAccFSxOntapVolume_tags
=== PAUSE TestAccFSxOntapVolume_tags
=== RUN   TestAccFSxOntapVolume_tieringPolicy
=== PAUSE TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_basic
=== CONT  TestAccFSxOntapVolume_size
=== CONT  TestAccFSxOntapVolume_securityStyle
=== CONT  TestAccFSxOntapVolume_name
=== CONT  TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_junctionPath
=== CONT  TestAccFSxOntapVolume_tags
=== CONT  TestAccFSxOntapVolume_storageEfficiency
=== CONT  TestAccFSxOntapVolume_disappears
--- PASS: TestAccFSxOntapVolume_basic (2981.50s)
--- PASS: TestAccFSxOntapVolume_disappears (2983.29s)
--- PASS: TestAccFSxOntapVolume_storageEfficiency (3076.46s)
--- PASS: TestAccFSxOntapVolume_tags (3079.03s)
--- PASS: TestAccFSxOntapVolume_size (3122.38s)
--- PASS: TestAccFSxOntapVolume_junctionPath (3199.02s)
--- PASS: TestAccFSxOntapVolume_securityStyle (3350.74s)
--- PASS: TestAccFSxOntapVolume_tieringPolicy (3425.77s)
--- PASS: TestAccFSxOntapVolume_name (3576.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3579.929s

Verified Acceptance Tests in GovCloud (us-gov-west-2)

make testacc TESTARGS='-run=TestAccFSxOntapVolume' PKG_NAME=internal/service/fsx TEST_COUNT=1 ACCTEST_PARALLELISM=10
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 10 -run=TestAccFSxOntapVolume -timeout 180m
=== RUN   TestAccFSxOntapVolume_basic
=== PAUSE TestAccFSxOntapVolume_basic
=== RUN   TestAccFSxOntapVolume_disappears
=== PAUSE TestAccFSxOntapVolume_disappears
=== RUN   TestAccFSxOntapVolume_name
=== PAUSE TestAccFSxOntapVolume_name
=== RUN   TestAccFSxOntapVolume_junctionPath
=== PAUSE TestAccFSxOntapVolume_junctionPath
=== RUN   TestAccFSxOntapVolume_securityStyle
=== PAUSE TestAccFSxOntapVolume_securityStyle
=== RUN   TestAccFSxOntapVolume_size
=== PAUSE TestAccFSxOntapVolume_size
=== RUN   TestAccFSxOntapVolume_storageEfficiency
=== PAUSE TestAccFSxOntapVolume_storageEfficiency
=== RUN   TestAccFSxOntapVolume_tags
=== PAUSE TestAccFSxOntapVolume_tags
=== RUN   TestAccFSxOntapVolume_tieringPolicy
=== PAUSE TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_basic
=== CONT  TestAccFSxOntapVolume_size
=== CONT  TestAccFSxOntapVolume_tieringPolicy
=== CONT  TestAccFSxOntapVolume_storageEfficiency
=== CONT  TestAccFSxOntapVolume_junctionPath
=== CONT  TestAccFSxOntapVolume_tags
=== CONT  TestAccFSxOntapVolume_disappears
=== CONT  TestAccFSxOntapVolume_name
=== CONT  TestAccFSxOntapVolume_securityStyle
--- PASS: TestAccFSxOntapVolume_disappears (2691.94s)
--- PASS: TestAccFSxOntapVolume_size (2876.80s)
--- PASS: TestAccFSxOntapVolume_tags (2891.48s)
--- PASS: TestAccFSxOntapVolume_basic (2959.48s)
--- PASS: TestAccFSxOntapVolume_junctionPath (2959.80s)
--- PASS: TestAccFSxOntapVolume_securityStyle (2995.90s)
--- PASS: TestAccFSxOntapVolume_storageEfficiency (3033.19s)
--- PASS: TestAccFSxOntapVolume_tieringPolicy (3368.95s)
--- PASS: TestAccFSxOntapVolume_name (3397.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3401.044s

@breathingdust breathingdust merged commit 38fd510 into hashicorp:main Nov 25, 2021
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Nov 25, 2021
@github-actions github-actions bot added this to the v3.67.0 milestone Nov 25, 2021
This was referenced Nov 26, 2021
Closed
Merged
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@awsaxeman @DrFaust92 @breathingdust @justinretzolk